[PATCH] D56839: [llvm-objcopy] [COFF] Implement --strip-debug

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-objcopy/COFF/strip-debug.test:1
+RUN: yaml2obj %p/Inputs/strip-sections.yaml > %t.in.o
+
----------------
Are you planning on using this yaml file for other tests? Otherwise, it seems confusingly named.


================
Comment at: test/tools/llvm-objcopy/COFF/strip-debug.test:3
+
+RUN: llvm-objdump -section-headers %t.in.o | FileCheck %s --check-prefixes=SECTIONS,SECTIONS-PRE
+RUN: llvm-objdump -t %t.in.o | FileCheck %s --check-prefixes=SYMBOLS,SYMBOLS-PRE
----------------
Nit, you're being inconsistent with using single and double-dashes for your options in this file. I prefer double, to avoid theoretical issues with grouping of single-letter options.


================
Comment at: test/tools/llvm-objcopy/COFF/strip-debug.test:7
+RUN: llvm-objcopy --strip-debug %t.in.o %t.out.o
+RUN: llvm-objdump -section-headers %t.out.o | FileCheck %s --check-prefixes=SECTIONS,SECTIONS-POST
+RUN: llvm-objdump -t %t.out.o | FileCheck %s --check-prefixes=SYMBOLS
----------------
What is SECTIONS-POST for, here and below? I can't see any check patterns for it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56839/new/

https://reviews.llvm.org/D56839