[PATCH] D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/DebugInfo/llvm-symbolizer.test:42-46
+Ensure that --no-demangle flag exceeds --demangle
+
+RUN: cd %t
+RUN: llvm-symbolizer --functions=linkage --inlining --demangle --no-demangle \
+RUN:    --default-arch=i386 < %t.input | FileCheck --check-prefix=CHECK --check-prefix=SPLIT --check-prefix=DWO %s
----------------
I think it would make more sense to extend the case below that you have already added --no-demangle to.

There you can test it something like the following (add the "DEMANGLED_FUNCTION_NAME" alongside the "SHORT_FUNCTION_NAME" check pattern):
```
RUN: llvm-symbolizer --functions=short --demangle --no-demangle < %t.input7 \
RUN:    | FileCheck %s --check-prefix=SHORT_FUNCTION_NAME
RUN: llvm-symbolizer --functions=short --no-demangle --demangle < %t.input7 \
RUN:    | FileCheck %s --check-prefix=DEMANGLED_FUNCTION_NAME

DEMANGLED_FUNCTION_NAME: c()
```


================
Comment at: tools/llvm-symbolizer/llvm-symbolizer.cpp:211-212
+  // the last one as demangle option.
+  if (ClNoDemangle.getPosition() > ClDemangle.getPosition())
+    ClDemangle = !ClNoDemangle;
+
----------------
Nice! I didn't know about the `getPosition` function.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56773/new/

https://reviews.llvm.org/D56773