[PATCH] D56780: [llvm-objdump] - Dump the archive headers when -all-headers is specified

Thu Jan 17 06:20:45 PST 2019

grimar marked an inline comment as done.
grimar added inline comments.

================
Comment at: test/tools/llvm-objdump/all-headers.test:17
+
+# RUN: yaml2obj %s > %t2
+# RUN: rm -f %t.a
----------------
grimar wrote:
> jhenderson wrote:
> > Not that it really matters, but I wonder if it would be better to simply copy %t?
> I have no preference. Actually, we can even use the existent file twice, what do you think?
> (it works, I just tested).
> 
i.e. with
`llvm-ar rcs t.a t1.o t1.o`
`llvm-objdump t.a --all-headers`

It then dumps them both as expected:

```
t.a(t1.o):	file format ELF64-x86-64

...

t.a(t1.o):	file format ELF64-x86-64

....
```

The name is the same, but since we want to test the headers order, that should be fine I think.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56780/new/

https://reviews.llvm.org/D56780