[PATCH] D56780: [llvm-objdump] - Dump the archive headers when -all-headers is specified

Thu Jan 17 06:06:21 PST 2019

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM with one nit. I think it would make more sense for the archive header to appear before the file header (the archive header is conceptually before the file header in the archive, and isn't really part of the ELF file itself), but like you said, that is a different change.

================
Comment at: test/tools/llvm-objdump/all-headers.test:15
+## Check how we dump the archives.
+## Check we dump the appropriate headers for each file in archive.
+
----------------
in archive -> in the archive

================
Comment at: test/tools/llvm-objdump/all-headers.test:17
+
+# RUN: yaml2obj %s > %t2
+# RUN: rm -f %t.a
----------------
Not that it really matters, but I wonder if it would be better to simply copy %t?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56780/new/

https://reviews.llvm.org/D56780