[PATCH] D56842: [llvm-objdump] - Move getRelocationValueString and dependenices out of the llvm-objdump.cpp

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

> It depends on D56721 <https://reviews.llvm.org/D56721> that was LGTMed but not yet landed.

FYI, I'm just verifying the latest version of this, following the last batch of updates, and I'll commit it after it's passed the test.

LGTM. I agree with your reasoning for moving them.



================
Comment at: tools/llvm-objdump/llvm-objdump.h:74
+
+class SectionFilterIterator {
+public:
----------------
This is probably fine as is, but I wonder if it actually belongs in the Object library?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56842/new/

https://reviews.llvm.org/D56842