[PATCH] D56842: [llvm-objdump] - Move getRelocationValueString and dependenices out of the llvm-objdump.cpp

[George Rimar via Phabricator via llvm-commits]

grimar created this revision.
grimar added reviewers: jhenderson, erik.pilkington, rupprecht, rnk, labath, zturner.
Herald added subscribers: sunfish, aheejin, sbc100, dschuff.

`getRelocationValueString` is a dispatcher function that calls the
corresponding ELF/COFF/Wasm/MachO implementations
that currently live in the llvm-objdump.cpp file.

I think these implementations should be moved to ELFDump.cpp,
 COFFDump.cpp and other corresponding files, to move platform specific
implementation out from the common logic.

The patch does that. Also, I had move `ToolSectionFilter` helper and `SectionFilterIterator`,
`SectionFilter` to a header to make them available across the objdump code.
That was needed for COFF, other implementations do not use `ToolSectionFilter`.
But it should be OK.

It depends on D56721 <https://reviews.llvm.org/D56721> that was LGTMed but not yet landed.


https://reviews.llvm.org/D56842

Files:
  tools/llvm-objdump/COFFDump.cpp
  tools/llvm-objdump/ELFDump.cpp
  tools/llvm-objdump/MachODump.cpp
  tools/llvm-objdump/WasmDump.cpp
  tools/llvm-objdump/llvm-objdump.cpp
  tools/llvm-objdump/llvm-objdump.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56842.182240.patch
Type: text/x-patch
Size: 35064 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190117/27102c79/attachment.bin>