[PATCH] D56831: [NewPM] Add -fsanitize={memory, thread} handling to clang

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1016-1017
 
       // Register callbacks to schedule sanitizer passes at the appropriate part of
       // the pipeline.
       if (LangOpts.Sanitize.has(SanitizerKind::LocalBounds))
----------------
Add a FIXME about ASan?

Actually, if you don't mind, could you add code to detect ASan (and any other sanitizers you see in the parallel code) and emit a fatal error and put the FIXME there? I really should have done this to begin with. We should never *ignore* the flag.

Follow-up patch is probably better at that point, and include Richard or Reid on it to make sure its an acceptable way to handle the error.

I don't think we need to produce a full fledged diagnostic here -- this isn't related to the code at all, and this is essentially a "not implemented yet" as opposed to a useful thing for users.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56831/new/

https://reviews.llvm.org/D56831