[PATCH] D56754: Add Support for Creating and Deleting Unicode Files and Directories in Lit

[serge via Phabricator via llvm-commits]

serge-sans-paille added inline comments.


================
Comment at: utils/lit/lit/TestRunner.py:1087
     # Write script file
-    mode = 'w'
-    if litConfig.isWindows and not isWin32CMDEXE:
-      mode += 'b'  # Avoid CRLFs when writing bash scripts.
-    f = open(script, mode)
+    f = open(script, 'wb')
     if isWin32CMDEXE:
----------------
That's nce, but now, you need to use the `b` prefix for all strings, and for decoding o f the joined command, right?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56754/new/

https://reviews.llvm.org/D56754