[PATCH] D52002: Omit range checks from jump tables when lowering switches with unreachable default

Wed Jan 16 23:42:20 PST 2019

hans accepted this revision.
hans added a comment.

In D52002#1359790 <https://reviews.llvm.org/D52002#1359790>, @ayonam wrote:

> >> ayonam updated this revision to Diff 181000.Thu, Jan 10, 12:55
> >> Comment Actions
>
>
>
> >> The patch failed another test because the branch to the unreachable default was omitted. The test cases have been modified. The >>affected tests are test/CodeGen/X86/pr38743.ll and test/CodeGen/X86/switch-jump-table.ll
>
> I have no clue how the file test/CodeGen/X86/pr38743.ll got left out when I updated the revision on Jan 10.  I am updating this revision with that file added.
>
> @hans 
>  My sincere apologies for this rework.  The only changes are in test/CodeGen/X86/pr38743.ll.  Could you please quickly check if things are fine with that file and accept this patch?

No problem, I think I saw that change before. This still looks good.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52002/new/

https://reviews.llvm.org/D52002