[PATCH] D53765: [RFC prototype] Implementation of asm-goto support in LLVM

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D53765#1360880 <https://reviews.llvm.org/D53765#1360880>, @void wrote:

> There appears to be an ICE with this patch: https://github.com/ClangBuiltLinux/linux/issues/6#issuecomment-454675962


I think I see the issue. We need to return false for callbr from llvm::isSafeToSpeculativelyExecute. We probably also should fix to computeKnownBitsFromAssume to not visit an assume that is also the CxtI instruction. In that case we end up searching through the basic block until the terminator. And only because every terminator returns false from llvm::isSafeToSpeculativelyExecute do we end up terminating the loop without walking off the end of the basic block.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53765/new/

https://reviews.llvm.org/D53765