[PATCH] D56074: [NFC] Add detector function for explicitly expressed guards

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/one required change.



================
Comment at: include/llvm/Analysis/GuardUtils.h:23
 
+/// Returns true iff \p U is a branch that has semantics of a guard.
+bool isExplicitGuard(const User *U);
----------------
This comment applies to your whole set of reviews.

I would suggest avoiding the term "explicit".  Despite glancing at your patch titles a few times over the last week, I still get confused each time.  Is explicit the guard?  Or the widenable condition?  Possible alternate wording:
isWidenableBranchToDeopt?
isGuardAsWidenableBranch?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56074/new/

https://reviews.llvm.org/D56074