[PATCH] D56325: Sort symbols in .bss by size.

Vic Yang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 16 16:27:04 PST 2019


victoryang added a comment.

In D56325#1360770 <https://reviews.llvm.org/D56325#1360770>, @pcc wrote:

> In D56325#1360738 <https://reviews.llvm.org/D56325#1360738>, @victoryang wrote:
>
> > I was able to build and test Chrome on Android. Without this, the dirty pages from all libraries included in Chrome APK sum up to 364KB. With the symbols in those libraries sorted, this comes down to 360KB.
>
>
> How exactly did you get those figures? For measuring anything memory related in Chrome I'd recommend using the `system_health.memory_mobile` benchmarks (I'd be happy to help you run them).


I have a modified dynamic linker that tag each bss VM area with the library it corresponds to, and I only count those from libraries included in the APK (that is, libraries that I applied this change on). I didn't want to take memory usage as a whole because I worry the variation may be more than the change this is causing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56325/new/

https://reviews.llvm.org/D56325





More information about the llvm-commits mailing list