[PATCH] D56122: [CallSite removal] Migrate the statepoint GC infrastructure to use the `CallBase` class rather than `CallSite` wrappers.

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/one requested change before submit.  If you strongly disagree, feel free to land and discuss afterwards.  I don't want this blocked on me finding time to re-review.

Minor (can be easily cleaned up later): Using Call seems a bit confusing as a variable name.  I'd have preferred CB for consistency with other naming.

I see a bunch of follow on simplifications, but I can do a wave of small commits once this lands and bakes for a bit.



================
Comment at: llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:2379
 
-// Handles both return values and arguments for Functions and CallSites.
+// Handles both return values and arguments for Functions and calls.
 template <typename AttrHolder>
----------------
This looks like a spurious unrelated change.  I also don't see why passing by pointer is better than reference here.  Can you remove this from the diff please?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56122/new/

https://reviews.llvm.org/D56122