[PATCH] D56807: [WebAssembly] Merge producers section

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 16 15:29:33 PST 2019


sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: wasm/Writer.cpp:654
+        }
+      }
+    }
----------------
>From brazed from these two single line blocks.   That the lld style anyway.


================
Comment at: wasm/Writer.cpp:657
+  }
+  int Fields =
+      int(!Languages.empty()) + int(!Tools.empty()) + int(!SDKs.empty());
----------------
Call this FieldCount ?


================
Comment at: wasm/Writer.cpp:817
     createRelocSections();
   }
   if (!Config->StripDebug && !Config->StripAll)
----------------
Add another newline here for visual consistency?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56807/new/

https://reviews.llvm.org/D56807





More information about the llvm-commits mailing list