[PATCH] D56779: [ELF][X86_64] Fix corrupted LD -> LE optimization for TLS without PLT
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 16 14:44:12 PST 2019
ruiu added a comment.
We should cherrypick this patch to 8.0 branch so that 8.0 will be shipped with this fix included. I'll file a bug and do, so no worries.
================
Comment at: ELF/Arch/X86_64.cpp:281
};
- memcpy(Loc - 3, Inst, sizeof(Inst));
+ if (Loc[4] == 0xe8) {
+ // Convert
----------------
Lekensteyn wrote:
> ruiu wrote:
> > Add a blank line.
> Before the `if`? I will also fix the wrong indentation for the comment.
Yes. I would add a blank line before `if` so that the variable definition and `if` doesn't come too close.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56779/new/
https://reviews.llvm.org/D56779
More information about the llvm-commits
mailing list