[PATCH] D56683: [llvm-objcopy] [COFF] Add support for removing sections
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 16 14:32:20 PST 2019
mstorsjo added a comment.
In D56683#1360543 <https://reviews.llvm.org/D56683#1360543>, @rupprecht wrote:
> It'd be nice if someone else could take a pass too, especially for any COFF-specific aspects, but LGTM
Thanks! @rnk - can you give this a peek? The main COFF specific details are updating section definition aux symbols if present, tracking the target of associative comdat sections. And if removing the target of an associative comdat, the associated section can be removed as well, to avoid leaving it dangling.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56683/new/
https://reviews.llvm.org/D56683
More information about the llvm-commits
mailing list