[PATCH] D56742: [WebAssembly] Parse llvm.ident into producers section

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 16 14:28:18 PST 2019


sbc100 accepted this revision.
sbc100 added inline comments.


================
Comment at: include/llvm/Object/Wasm.h:160
+    return SDKs;
+  }
 
----------------
Could we keep this interface simpler by putting these in a struct and have "getProducerInfo()" (see DylinkInfo).

Otherwise lgtm


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56742/new/

https://reviews.llvm.org/D56742





More information about the llvm-commits mailing list