[PATCH] D56801: Fix most of LLVM's tests with LLVM_ENABLE_PIC=OFF

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 16 12:42:58 PST 2019


thakis created this revision.
thakis added a reviewer: pcc.
Herald added subscribers: dexonsmith, mehdi_amini, mgorny.

Lots of tests rely on llvm-lto being present, but LLVM_ENABLE_PIC=OFF currently disables building that executable.

There's no reason for not building llvm-lto with LLVM_ENABLE_PIC=OFF so just build it. r191042 moved it into a "if (!WIN)" block at the time, and then 211852 made that "if(NOT CYGWIN AND LLVM_ENABLE_PIC)" -- but that's only needed for LTO (the ld64 plugin), not for the llvm-lto binary.


https://reviews.llvm.org/D56801

Files:
  tools/CMakeLists.txt


Index: tools/CMakeLists.txt
===================================================================
--- tools/CMakeLists.txt
+++ tools/CMakeLists.txt
@@ -27,7 +27,6 @@
 
 if(CYGWIN OR NOT LLVM_ENABLE_PIC)
   set(LLVM_TOOL_LTO_BUILD Off)
-  set(LLVM_TOOL_LLVM_LTO_BUILD Off)
 endif()
 
 # Add LTO, llvm-ar, llvm-config, and llvm-profdata before clang, ExternalProject


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56801.182123.patch
Type: text/x-patch
Size: 363 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190116/35b83157/attachment.bin>


More information about the llvm-commits mailing list