[PATCH] D56767: [AsmPrinter] Collapse .loc 0 0 directives

Wed Jan 16 11:26:22 PST 2019

aprantl added inline comments.

================
Comment at: test/DebugInfo/MIR/X86/debug-loc-0.mir:23
+    %s1.addr = alloca i8*, align 8
+    call void @llvm.dbg.declare(metadata i8** %s1.addr, metadata !11, metadata !DIExpression(DW_OP_deref)), !dbg !16
+    %0 = bitcast i8** %s1.addr to %swift.opaque**
----------------
I don't think this is needed either, right? Line tables only should be sufficient,

================
Comment at: test/DebugInfo/MIR/X86/debug-loc-0.mir:48
+
+  !0 = distinct !DICompileUnit(language: DW_LANG_Swift, file: !1, producer: "Swift version 4.2.1-dev effective-3.4.1 (LLVM 4ba03d9389, Clang 78aa734eee, Swift f4134ebef6)", isOptimized: false, flags: "-target x86_64-apple-macosx10.9 -module-cache-path /Users/jonas/swift/build/Ninja-ReleaseAssert/swift-macosx-x86_64/./swift-test-results/x86_64-apple-macosx10.9/clang-module-cache -sdk /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -swift-version 3 -g -I /Users/jonas/swift/build/Ninja-ReleaseAssert/swift-macosx-x86_64/test-macosx-x86_64/DebugInfo/Output/struct_resilience.swift.tmp -emit-ir -enable-resilience /Users/jonas/swift/swift/test/DebugInfo/struct_resilience.swift -o /tmp/41.ll -resource-dir /Users/jonas/swift/build/Ninja-ReleaseAssert/swift-macosx-x86_64/lib/swift", runtimeVersion: 4, emissionKind: FullDebug, enums: !2, imports: !2)
+  !1 = !DIFile(filename: "/Users/jonas/swift/swift/test/DebugInfo/struct_resilience.swift", directory: "/Users/jonas/swift")
----------------
personally I would probably also remove all the paths

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56767/new/

https://reviews.llvm.org/D56767