[PATCH] D56721: Move llvm-objdump demangle function into demangler library

Wed Jan 16 10:23:21 PST 2019

erik.pilkington accepted this revision.
erik.pilkington added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

================
Comment at: lib/Demangle/Demangle.cpp:23
+  char *Demangled = nullptr;
+  if (strncmp(MangledName, "_Z", 2) == 0)
+    Demangled = itaniumDemangle(MangledName, Demangled, nullptr, nullptr);
----------------
jhenderson wrote:
> grimar wrote:
> > erik.pilkington wrote:
> > > You should probably also send strings that start with "___Z" to the itanium demangler.
> > This patch just moves the existent code, I would not add any additional functionality in it.
> I agree, though I don't mind it being in a follow-up change, if desired. The main advantage of this change as is, is that it is a pure refactor (there might be some minor differences in performance, but the end behaviour should be identical to what llvm-objdump previously did).
Sure, doing this in a follow-up is fine.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56721/new/

https://reviews.llvm.org/D56721