[PATCH] D56720: [MemorySSA] Add caching results of reaching LiveOnEntry MemoryDef to ClobberWalker

Evgeny Astigeevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 16 10:15:18 PST 2019


eastig added a comment.

Hi George,

Thank you for the comments and advice.

There is a problem with using `constexpr`. The VIXL library is built with c++98 by default. I'll speak to VIXL developers whether it is still a requirement.

I agree with you any caching is a source of bugs. I prefer using heuristics to adding functionality producing bugs.
I am not sure the current caching prototype is bug-free. I made some assumptions which might not be always true.

As the case is definitely pathological I'd be happy to have some kind of heuristics to filter it out.
I appreciate if someone familiar with the MemorySSA code adds the heuristics. If everyone is busy, I can try to do.

Thanks,
Evgeny


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56720/new/

https://reviews.llvm.org/D56720





More information about the llvm-commits mailing list