[PATCH] D55293: [LLD][COFF] Partial sections

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 16 09:51:57 PST 2019


aganea updated this revision to Diff 182074.
aganea marked 10 inline comments as done.
aganea retitled this revision from "[LLD][COFF] Unmerged sections" to "[LLD][COFF] Partial sections".
aganea edited the summary of this revision.
aganea added a comment.

Updated following @ruiu 's comments - thank you!

I wasn't happy with the `UnmergedSection` name either - I changed that into `PartialSection`. If could also be `PartialOutSection` if we want to better designate the destination.

I also removed the `struct NameAndChars` because the concept was overlapping with data in `PartialSection`; that changed the `std::map` into a `std::set` and a custom comparer which uses part of `PartialSection` 's data as the "key".


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55293/new/

https://reviews.llvm.org/D55293

Files:
  COFF/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55293.182074.patch
Type: text/x-patch
Size: 9646 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190116/9d6b99c5/attachment.bin>


More information about the llvm-commits mailing list