[PATCH] D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`.
Dan Liew via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 16 08:18:41 PST 2019
delcypher marked 5 inline comments as done.
delcypher added inline comments.
================
Comment at: lib/sanitizer_common/sanitizer_vm_read_context.h:50
+ // Returns `nullptr` if no successful read has been performed.
+ void* GetLocalAddress() const { return (void*)local_address; }
+
----------------
delcypher wrote:
> vitalybuka wrote:
> > Please remove all stuff you are not using in upcoming patches.
> > When can extend API when needed
> >
> I'll have a look through my out-of-tree implementation and see what I can remove.
I've removed several fields/methods from this patch that weren't being used in my internal implementation.
Repository:
rCRT Compiler Runtime
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56206/new/
https://reviews.llvm.org/D56206
More information about the llvm-commits
mailing list