[PATCH] D56754: Add Support for Creating and Deleting Unicode Files and Directories in Lit

[serge via Phabricator via llvm-commits]

serge-sans-paille added inline comments.


================
Comment at: utils/lit/lit/TestRunner.py:1110
+            f.write('{ ' + '; } &&\n{ '.join(commands) + '; }')
+    f.write(b'\n' if mode == 'wb' else '\n')
     f.close()
----------------
I'm not 100% sure here, but this looks very redundant and non-maintainable. Why not always open the file in binary mode?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56754/new/

https://reviews.llvm.org/D56754