[PATCH] D56778: [llvm-objdump] - Simplify the getRelocationValueString. NFCI.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 16 05:38:39 PST 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one nit.



================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:501
+  // In SHT_REL case we would need to read the addend from section data.
+  // GNU objdump does not do that and we just follow for simplicity atm.
   bool Undef = false;
----------------
Delete the "atm".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56778/new/

https://reviews.llvm.org/D56778





More information about the llvm-commits mailing list