[PATCH] D56721: Move llvm-objdump demangle function into demangler library

[James Henderson via Phabricator via llvm-commits]

jhenderson updated this revision to Diff 182000.
jhenderson marked 7 inline comments as done.
jhenderson added a comment.

Address review comments:

- Switch to .str().c_str() to ensure null-termination instead of assert
- clang-format
- Fix doc comment
- Pass in nullptr into demangle functions explicitly
- change namespacing style


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56721/new/

https://reviews.llvm.org/D56721

Files:
  include/llvm/Demangle/Demangle.h
  lib/Demangle/CMakeLists.txt
  lib/Demangle/Demangle.cpp
  tools/llvm-objdump/llvm-objdump.cpp
  unittests/Demangle/CMakeLists.txt
  unittests/Demangle/DemangleTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56721.182000.patch
Type: text/x-patch
Size: 5358 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190116/900dbd36/attachment.bin>