[PATCH] D56765: [X86] Add a one use check to the setcc inversion code in combineVSelectWithAllOnesOrZeros

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 16 01:56:11 PST 2019


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM but a test case would be useful.



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:33851
   // Try to invert the condition if true value is not all 1s and false value is
   // not all 0s.
+  if (!TValIsAllOnes && !FValIsAllZeros && Cond.hasOneUse() &&
----------------
Update comment?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56765/new/

https://reviews.llvm.org/D56765





More information about the llvm-commits mailing list