[PATCH] D55943: [RuntimeDyld] load all non-relocation sections with ProcessAllSections

[Lang Hames via Phabricator via llvm-commits]

lhames requested changes to this revision.
lhames added a comment.
This revision now requires changes to proceed.

Hi Yonghong,

ProcessAllSections is kind of subtle. It is up to the user allocator whether the section is actually allocated in the end, but it means that you should call findOrEmit for every section in the object file, regardless of whether or not RuntimeDyld deems it reachable. Its original purpose was as a hack to ensure that clients could get access to debug and other metadata sections that would have otherwise been dropped.

Given that, I think the following check should be removed:

  if (RelocatedSection != SE)
    continue;

When ProcessAllSections is set, even non-relocatable sections should be emitted.

Otherwise this looks good to me.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55943/new/

https://reviews.llvm.org/D55943