[PATCH] D56743: [llvm-rc] Support '--' for delimiting options from input paths

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo marked an inline comment as done.
mstorsjo added inline comments.


================
Comment at: tools/llvm-rc/llvm-rc.cpp:91
+      std::find_if(Argv + 1, Argv + Argc,
+                   [](const char *str) { return strcmp(str, "--") == 0; });
+  ArrayRef<const char *> ArgsArr = makeArrayRef(Argv + 1, DashDash);
----------------
zturner wrote:
> Should this be `" -- "`?  I don't think `llvm-rc.exe foo--bar` should trigger this, that's one argument that happens to have 2 dashes.   
Yes, but this is `strcmp` on a per-argument basis, not `strstr` on the concatenated command line. `strcmp("foo--bar", "--")` doesn't return 0.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56743/new/

https://reviews.llvm.org/D56743