[PATCH] D56516: [SanitizerCoverage] Don't create comdat for weak functions.
Matt Morehouse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 15 13:08:16 PST 2019
morehouse updated this revision to Diff 181863.
morehouse marked an inline comment as done.
morehouse added a comment.
- Apply change to all interposable linkages.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56516/new/
https://reviews.llvm.org/D56516
Files:
llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
llvm/test/Instrumentation/SanitizerCoverage/interposable-symbol-nocomdat.ll
Index: llvm/test/Instrumentation/SanitizerCoverage/interposable-symbol-nocomdat.ll
===================================================================
--- /dev/null
+++ llvm/test/Instrumentation/SanitizerCoverage/interposable-symbol-nocomdat.ll
@@ -0,0 +1,38 @@
+; Test that interposable symbols do not get put in comdats.
+; RUN: opt < %s -sancov -sanitizer-coverage-level=3 -sanitizer-coverage-trace-pc-guard -S | FileCheck %s
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+define void @Vanilla() {
+entry:
+ ret void
+}
+
+define linkonce void @LinkOnce() {
+entry:
+ ret void
+}
+
+define weak void @Weak() {
+entry:
+ ret void
+}
+
+declare extern_weak void @ExternWeak()
+
+define linkonce_odr void @LinkOnceOdr() {
+entry:
+ ret void
+}
+
+define weak_odr void @WeakOdr() {
+entry:
+ ret void
+}
+
+; CHECK: define void @Vanilla() comdat {
+; CHECK: define linkonce void @LinkOnce() {
+; CHECK: define weak void @Weak() {
+; CHECK: declare extern_weak void @ExternWeak()
+; CHECK: define linkonce_odr void @LinkOnceOdr() comdat {
+; CHECK: define weak_odr void @WeakOdr() comdat {
Index: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
===================================================================
--- llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
+++ llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
@@ -568,7 +568,7 @@
*CurModule, ArrayTy, false, GlobalVariable::PrivateLinkage,
Constant::getNullValue(ArrayTy), "__sancov_gen_");
- if (TargetTriple.supportsCOMDAT())
+ if (TargetTriple.supportsCOMDAT() && !F.isInterposable())
if (auto Comdat =
GetOrCreateFunctionComdat(F, TargetTriple, CurModuleUniqueId))
Array->setComdat(Comdat);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56516.181863.patch
Type: text/x-patch
Size: 1789 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190115/1e233124/attachment-0001.bin>
More information about the llvm-commits
mailing list