[PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv
    Hui Huang via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Jan 15 11:18:07 PST 2019
    
    
  
Hui added a comment.
> - drop the `if (m_entries[i].quote)` branch. You don't need it here, and I don't believe it will be correct anyway, because all it will do is cause `llvm::sys::flattenWindowsCommandLine` to add one more quote level around that and escape the quotes added by yourself
The quote char might be specified through Args::AppendArgument at user's will.
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56230/new/
https://reviews.llvm.org/D56230
    
    
More information about the llvm-commits
mailing list