[PATCH] D56727: gn build: Don't assume valgrind.h exists on Linux

[Hans Wennborg via Phabricator via llvm-commits]

hans created this revision.
hans added reviewers: thakis, pcc.

It didn't on my machine, so defaulting it to off seems better.


https://reviews.llvm.org/D56727

Files:
  llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn


Index: llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn
===================================================================
--- llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn
+++ llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn
@@ -152,11 +152,8 @@
     ]
   }
 
-  if (current_os == "linux") {
-    values += [ "HAVE_VALGRIND_VALGRIND_H=1" ]
-  } else {
-    values += [ "HAVE_VALGRIND_VALGRIND_H=" ]
-  }
+  # Even Linux systems often don't have valgrind.h, so default it to off.
+  values += [ "HAVE_VALGRIND_VALGRIND_H=" ]
 
   if (current_os == "mac") {
     values += [


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56727.181796.patch
Type: text/x-patch
Size: 605 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190115/ddd4e4a7/attachment.bin>