[PATCH] D56695: [X86] Add X86ISD::VSHLV and X86ISD::VSRLV nodes for psllv and psrlv

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86InstrSSE.td:8402
   def : Pat<(v8i32 (X86vsrav VR256:$src1, (load addr:$src2))),
             (VPSRAVDYrm VR256:$src1, addr:$src2)>;
 }
----------------
zhutianyang wrote:
> RKSimon wrote:
> > RKSimon wrote:
> > > Worth wrapping these in a defm macro to reduce duplication?
> > We could even move the patterns inside avx2_var_shift now that all users want them.
> I think you have some good ideas, could you share a demo again?
> To be frankly, I am not familial with td programming, Thanks.
Actually this isn't going to work as VPSRAVQ doesn't exist on AVX2 - let's leave it as this.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56695/new/

https://reviews.llvm.org/D56695