[PATCH] D56629: [llvm-readelf] Allow single-letter flags to be merged.

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht marked an inline comment as done.
rupprecht added inline comments.


================
Comment at: test/tools/llvm-readobj/dyn-symbols.test:38
+# CHECK-NEXT:   Symbol {
+# CHECK-NEXT:     Name: _ITM_deregisterTMCloneTable
+# CHECK-NEXT:     Value: 0x0
----------------
jhenderson wrote:
> Here and below, could you check that there are no extraneous characters at the end of the name, by putting a {{$}} at the end, please? This would match other names for which this is a prefix. You might need to capture the string offset as a result.
The actual output here is `_ITM_deregisterTMCloneTable (28)`, so I used `{{ }}` instead, as `{{$}}` fails due to the trailing `(28)`. I verified that truncating the name (e.g. `_ITM_deregisterTMCloneTabl{{ }}`) causes the test to fail.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56629/new/

https://reviews.llvm.org/D56629