[PATCH] D56714: [SLP] introduce control over arithmetic horizontal reduction

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 15 07:17:15 PST 2019


fedor.sergeev added a comment.

In D56714#1357679 <https://reviews.llvm.org/D56714#1357679>, @RKSimon wrote:

> I'm really not sure about this - PR40310 is most likely a bug in the reduction code so isn't it likely that Add/FAdd can be affected by it as well?


I'm not pushing this particular solution, its here only as a possible short-term.
However, I need to note that we have fuzzer running continuously and it started regularly finding bugs in reduction only after the aforementioned change went in.
Since late-October time we found ~10 different variations of it.

Given that we had no fuzzer bugs found in the vicinity of this code before late-October, it is safe to conclude that Add/FAdd does not trigger
the bug anywhere that often, even if the bug is in a common code.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56714/new/

https://reviews.llvm.org/D56714





More information about the llvm-commits mailing list