[PATCH] D56713: gn build: Add check-hwasan target.

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 15 06:13:27 PST 2019


thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Nice!!



================
Comment at: llvm/utils/gn/secondary/compiler-rt/test/hwasan/BUILD.gn:47
+    } else {
+      deps += [ "//llvm/tools/llvm-symbolizer($host_toolchain)" ]
+    }
----------------
Why do you need the android special case here?


================
Comment at: llvm/utils/gn/secondary/compiler-rt/test/test.gni:15
+  }
+  target_flags_string += flag
+}
----------------
Oooh I guess this would be tricky to do when using GN's config stuff for target flags. Hmm…


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56713/new/

https://reviews.llvm.org/D56713





More information about the llvm-commits mailing list