[PATCH] D56538: [NewPM][TSan] Reiterate the TSan port

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

OK, this makes sense to me now. Minor comment below, but LGTM with that.



================
Comment at: llvm/lib/Transforms/Utils/ModuleUtils.cpp:183-184
+                                               StringRef VersionCheckName) {
+  assert(!CtorName.empty() && "Expected ctor function name");
+  if (Function *Ctor = M.getFunction(CtorName))
+    if (Ctor->arg_size() == 0 ||
----------------
Can you add a FIXME to sink the get-or-insert style logic into the module API much like we have for globals?

That will (eventually) make this much easier to move into a concurrent model.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56538/new/

https://reviews.llvm.org/D56538