[PATCH] D56591: [llvm-symbolizer] Add -C as a short alias to -demangle

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/DebugInfo/llvm-symbolizer.test:218
+RUN: llvm-symbolizer --functions=short --use-symbol-table=false -C=false < %t.input7 \
+RUN:    | FileCheck %s --check-prefix=DEMANGLE_ALIAS_SHORT_FUNCTION_NAME
+
----------------
You don't need a new check-prefix. You can reuse the existing one. You also don't need to recreate %t.input7.


================
Comment at: test/tools/llvm-symbolizer/pdb/pdb.test:8
+RUN: grep '^ADDR:' %s | sed -s 's/ADDR: //' \
+RUN: 	| llvm-symbolizer -obj="%p/Inputs/test.exe" -C=false \
+RUN: 	| FileCheck %s --check-prefix=CHECK-NO-DEMANGLE
----------------
ruiu wrote:
> This is not a new test because we have a test that exercises `-demangle=false`, but what is the "false" format style? addr2line reports an error if an argument given to `--demangle`  or `-C` is not known.
Interesting catch. That wasn't something I noticed. llvm-symbolizer treats --demangle (and therefore -C) as a boolean switch, rather than one that takes a style, i.e. --demangle=false disables demangling.

It's worth noting that unlike addr2line, demangling is on by default too, so this switch only needs to exist for a) compatibility, and b) so that demangling can be disabled, unless we change the default (which could break people's workflows...).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56591/new/

https://reviews.llvm.org/D56591