[llvm] r351173 - [llvm-objcopy] [COFF] Remove pointless comment chars from .test files. NFC.

Martin Storsjo via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 15 01:34:46 PST 2019


Author: mstorsjo
Date: Tue Jan 15 01:34:45 2019
New Revision: 351173

URL: http://llvm.org/viewvc/llvm-project?rev=351173&view=rev
Log:
[llvm-objcopy] [COFF] Remove pointless comment chars from .test files. NFC.

Modified:
    llvm/trunk/test/tools/llvm-objcopy/COFF/strip-reloc-symbol.test
    llvm/trunk/test/tools/llvm-objcopy/COFF/strip-symbol.test

Modified: llvm/trunk/test/tools/llvm-objcopy/COFF/strip-reloc-symbol.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-objcopy/COFF/strip-reloc-symbol.test?rev=351173&r1=351172&r2=351173&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-objcopy/COFF/strip-reloc-symbol.test (original)
+++ llvm/trunk/test/tools/llvm-objcopy/COFF/strip-reloc-symbol.test Tue Jan 15 01:34:45 2019
@@ -1,5 +1,5 @@
-# RUN: yaml2obj %p/Inputs/strip-symbols.yaml > %t.o
-# RUN: not llvm-objcopy -N foo %t.o 2>&1 | FileCheck %s --check-prefix=ERROR
-# RUN: not llvm-objcopy --strip-symbol foo %t.o 2>&1 | FileCheck %s --check-prefix=ERROR
+RUN: yaml2obj %p/Inputs/strip-symbols.yaml > %t.o
+RUN: not llvm-objcopy -N foo %t.o 2>&1 | FileCheck %s --check-prefix=ERROR
+RUN: not llvm-objcopy --strip-symbol foo %t.o 2>&1 | FileCheck %s --check-prefix=ERROR
 
-# ERROR: error: '{{.*}}{{/|\\}}strip-reloc-symbol.test.tmp.o': not stripping symbol 'foo' because it is named in a relocation.
+ERROR: error: '{{.*}}{{/|\\}}strip-reloc-symbol.test.tmp.o': not stripping symbol 'foo' because it is named in a relocation.

Modified: llvm/trunk/test/tools/llvm-objcopy/COFF/strip-symbol.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-objcopy/COFF/strip-symbol.test?rev=351173&r1=351172&r2=351173&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-objcopy/COFF/strip-symbol.test (original)
+++ llvm/trunk/test/tools/llvm-objcopy/COFF/strip-symbol.test Tue Jan 15 01:34:45 2019
@@ -1,32 +1,32 @@
-# RUN: yaml2obj %p/Inputs/strip-symbols.yaml > %t.in.o
+RUN: yaml2obj %p/Inputs/strip-symbols.yaml > %t.in.o
 
-# RUN: llvm-readobj -relocations %t.in.o | FileCheck %s --check-prefixes=RELOCS,RELOCS-PRE
-# RUN: llvm-objdump -t %t.in.o | FileCheck %s --check-prefixes=SYMBOLS,SYMBOLS-PRE
+RUN: llvm-readobj -relocations %t.in.o | FileCheck %s --check-prefixes=RELOCS,RELOCS-PRE
+RUN: llvm-objdump -t %t.in.o | FileCheck %s --check-prefixes=SYMBOLS,SYMBOLS-PRE
 
-# RUN: llvm-objcopy -N mainfunc %t.in.o %t.out.o
-# RUN: llvm-readobj -relocations %t.out.o | FileCheck %s --check-prefixes=RELOCS,RELOCS-POST
-# RUN: llvm-objdump -t %t.out.o | FileCheck %s --check-prefix=SYMBOLS
-
-# RUN: llvm-objcopy --strip-symbol mainfunc %t.in.o %t.out.o
-# RUN: llvm-readobj -relocations %t.out.o | FileCheck %s --check-prefixes=RELOCS,RELOCS-POST
-# RUN: llvm-objdump -t %t.out.o | FileCheck %s --check-prefix=SYMBOLS
-
-# Explicitly listing the relocations for the input as well, to show
-# that the symbol index of the symbol foo is updated in the relocations,
-# while keeping relocations to two distinct .rdata symbols separate.
-
-# RELOCS:      Relocations [
-# RELOCS-NEXT:   Section (1) .text {
-# RELOCS-NEXT:     0x3 IMAGE_REL_AMD64_REL32 .rdata (0)
-# RELOCS-NEXT:     0xA IMAGE_REL_AMD64_REL32 .rdata (1)
-# RELOCS-PRE-NEXT:  0x11 IMAGE_REL_AMD64_REL32 foo (3)
-# RELOCS-POST-NEXT: 0x11 IMAGE_REL_AMD64_REL32 foo (2)
-# RELOCS-NEXT:   }
-# RELOCS-NEXT: ]
-
-# SYMBOLS: SYMBOL TABLE:
-# SYMBOLS-NEXT: .rdata
-# SYMBOLS-NEXT: .rdata
-# SYMBOLS-PRE-NEXT: mainfunc
-# SYMBOLS-NEXT: foo
-# SYMBOLS-EMPTY:
+RUN: llvm-objcopy -N mainfunc %t.in.o %t.out.o
+RUN: llvm-readobj -relocations %t.out.o | FileCheck %s --check-prefixes=RELOCS,RELOCS-POST
+RUN: llvm-objdump -t %t.out.o | FileCheck %s --check-prefix=SYMBOLS
+
+RUN: llvm-objcopy --strip-symbol mainfunc %t.in.o %t.out.o
+RUN: llvm-readobj -relocations %t.out.o | FileCheck %s --check-prefixes=RELOCS,RELOCS-POST
+RUN: llvm-objdump -t %t.out.o | FileCheck %s --check-prefix=SYMBOLS
+
+Explicitly listing the relocations for the input as well, to show
+that the symbol index of the symbol foo is updated in the relocations,
+while keeping relocations to two distinct .rdata symbols separate.
+
+RELOCS:      Relocations [
+RELOCS-NEXT:   Section (1) .text {
+RELOCS-NEXT:     0x3 IMAGE_REL_AMD64_REL32 .rdata (0)
+RELOCS-NEXT:     0xA IMAGE_REL_AMD64_REL32 .rdata (1)
+RELOCS-PRE-NEXT:  0x11 IMAGE_REL_AMD64_REL32 foo (3)
+RELOCS-POST-NEXT: 0x11 IMAGE_REL_AMD64_REL32 foo (2)
+RELOCS-NEXT:   }
+RELOCS-NEXT: ]
+
+SYMBOLS: SYMBOL TABLE:
+SYMBOLS-NEXT: .rdata
+SYMBOLS-NEXT: .rdata
+SYMBOLS-PRE-NEXT: mainfunc
+SYMBOLS-NEXT: foo
+SYMBOLS-EMPTY:




More information about the llvm-commits mailing list