[PATCH] D56474: [ARM] [NEON] Add ROTR/ROTL lowering

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:851
+    setOperationAction(ISD::ROTR, VT, Custom);
+    setOperationAction(ISD::FSHR, VT, Custom);
   }
----------------
If you're doing this please add suitable fshl/fshr test coverage

for reference:
llvm\test\CodeGen\X86\vector-fshl-128.ll
llvm\test\CodeGen\X86\vector-fshr-128.ll
llvm\test\CodeGen\X86\vector-fshl-rot-128.ll
llvm\test\CodeGen\X86\vector-fshr-rot-128.ll


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56474/new/

https://reviews.llvm.org/D56474