[PATCH] D56705: gn build: Make a couple of improvements to the unix toolchain.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc marked 2 inline comments as done.
pcc added inline comments.


================
Comment at: llvm/utils/gn/build/toolchain/BUILD.gn:44
+      depfile = "{{output}}.d"
+      command = "$cc -MMD -MF $depfile -o {{output}} -c {{source}} {{defines}} {{include_dirs}} $target_cflags"
+      depsformat = "gcc"
----------------
phosek wrote:
> This also needs `{{asmflags}}`.
Yes, also noticed that the description was wrong, fixed that too.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56705/new/

https://reviews.llvm.org/D56705