[PATCH] D56700: gn build: Add a resource_dir.gni file.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/utils/gn/secondary/llvm/resource_dir.gni:3
+
+llvm_resource_dir = "$root_build_dir/lib/clang/$llvm_version"
----------------
phosek wrote:
> Shouldn't this be `clang_resource_dir`? `clang/CMakeLists.txt` defines this as `CLANG_RESOURCE_DIR` and so does `clang/include/clang/Config/config.h`, `clang/lib/Driver/Driver.cpp` and `clang/lib/Frontend/CompilerInvocation.cpp`.
Works for me, done.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56700/new/

https://reviews.llvm.org/D56700