[PATCH] D56696: gn build: Rename llvm_host_triple to llvm_current_triple and have it use current_{cpu, os}.
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 14 23:06:11 PST 2019
phosek added inline comments.
================
Comment at: llvm/utils/gn/secondary/llvm/triples.gni:21
# The default target triple.
- llvm_target_triple = llvm_host_triple
+ llvm_target_triple = llvm_current_triple
}
----------------
Rather than replacing `llvm_host_triple` with `llvm_current_triple`, I think we should have both. This is going to be needed in some places, e.g. libc++, libc++abi, and libunwind lit configuration uses the host as well as the target triple, see https://github.com/llvm/llvm-project/blob/master/libcxx/test/lit.site.cfg.in#L18.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56696/new/
https://reviews.llvm.org/D56696
More information about the llvm-commits
mailing list