[PATCH] D56626: gn build: Stop defining LLVM_ON_UNIX globally.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 14 18:46:38 PST 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL351154: gn build: Stop defining LLVM_ON_UNIX globally. (authored by pcc, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D56626?vs=181404&id=181697#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56626/new/

https://reviews.llvm.org/D56626

Files:
  llvm/trunk/utils/gn/build/BUILD.gn


Index: llvm/trunk/utils/gn/build/BUILD.gn
===================================================================
--- llvm/trunk/utils/gn/build/BUILD.gn
+++ llvm/trunk/utils/gn/build/BUILD.gn
@@ -5,11 +5,6 @@
 config("compiler_defaults") {
   defines = []
 
-  # FIXME: Don't define this globally here.
-  if (host_os != "win") {
-    defines += [ "LLVM_ON_UNIX" ]
-  }
-
   if (!llvm_enable_assertions) {
     defines += [ "NDEBUG" ]
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56626.181697.patch
Type: text/x-patch
Size: 436 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190115/12ff7a29/attachment.bin>


More information about the llvm-commits mailing list