[PATCH] D56548: Fix emission of _fltused for MSVC.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 14 18:03:17 PST 2019


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

I have no idea how you ended up here, but looks good, just a few NFC comments. :)



================
Comment at: llvm/include/llvm/IR/Type.h:470
 
-//===----------------------------------------------------------------------===//
-// Provide specializations of GraphTraits to be able to treat a type as a
----------------
Seems unrelated?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:394
+
+  for (const_inst_iterator I = inst_begin(F), E = inst_end(F); I != E; ++I) {
+    if (I->getType()->isFPOrFPVectorTy()) {
----------------
`for (const Instruction &I : instructions(F))` ? That range-for helper is defined near `inst_begin`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56548/new/

https://reviews.llvm.org/D56548





More information about the llvm-commits mailing list