[PATCH] D56684: [WebAssembly] Fixed objdump not parsing function headers.

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 14 17:05:10 PST 2019


dschuff added a comment.

Is this actually what we want?
If I'm debugging a crash in a browser, the browser shows stack traces by function index rather than file offset, in this format 
`${url}:wasm-function[${funcIndex}]:${pcOffset}`
(see https://webassembly.github.io/spec/web-api/index.html#conventions)
So it might be better for objdump to match that format.

Is this change just for consistency (between targets) of printing, or is there another reason why it's better to have "addresses" be offsets rather than indices?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56684/new/

https://reviews.llvm.org/D56684





More information about the llvm-commits mailing list