[PATCH] D56617: [X86] Avoid clobbering ESP/RSP in the epilogue.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 14 13:41:15 PST 2019


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Thanks for the report and patch! Looks good. Do you need someone to commit this?



================
Comment at: test/CodeGen/X86/pr40289-64bit.ll:6
+  %2 = load volatile i64, i64* %1
+  ; CHECK-NOT: popq %rsp
+  ; CHECK: addq $8, %rsp
----------------
`popq %rsp`, hilarious. XD


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56617/new/

https://reviews.llvm.org/D56617





More information about the llvm-commits mailing list