[PATCH] D52845: Update entry count for cold calls

[David Callahan via Phabricator via llvm-commits]

david2050 marked 2 inline comments as done.
david2050 added inline comments.


================
Comment at: lib/IR/Function.cpp:1403-1404
 
+void Function::updateProfileData(int64_t entryDelta,
+                                 const ValueMap<const Value *, WeakTrackingVH> * VMap) {
+  auto CalleeCount = getEntryCount();
----------------
wmi wrote:
> It seems to me a little bit weird to have some structure specific for inliner in the interface of llvm IR. It looks more like a transformation utility and better to stay under lib/Transforms/Utils/. We may create a new file for it if there is nowhere else to put. 
> 
> And maybe make the name more explicit like updateCalleeProfile. 
I will try putting it back into InlineFunction and exporting it as a static method


================
Comment at: lib/Transforms/IPO/SampleProfile.cpp:326
+    uint64_t entryCount;
+    uint64_t samples;
+  };
----------------
wmi wrote:
> I don't find where samples is used?
part of  a subsequent patch, I will remove from here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52845/new/

https://reviews.llvm.org/D52845