[llvm] r350653 - Revert "Work around a linker error caused by https://reviews.llvm.org/D56084."

[Adrian Prantl via llvm-commits]

On Jan 14, 2019, at 11:59 AM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> Ah, thanks! What was the motivation for the workaround and what caused it to no longer be needed?

commit e45f5550935f94fdfee33a1a7ea42f82068c97da (HEAD -> master, origin/master, origin/HEAD)
Author: adrian <adrian at 91177308-0d34-0410-b5e6-96231b3b80d8>
Date:   Mon Jan 14 17:24:11 2019 +0000

    Reapply r345008 "Split MachinePipeliner code into header and cpp files"
    
    Split MachinePipeliner code into header and cpp files to allow
    inheritance from SwingSchedulerDAG.
    
    This reapplies https://reviews.llvm.org/D56084 after moving the
    implementation of the dump functions into the .cpp files. This fixes a
    linker error when building with Clang modules enables and local
    submodule visibility disabled.
    
    Original patch by Lama Saba <lama.saba at intel.com>!
    
    git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@351077 91177308-0d34-0410-b5e6-96231b3b80d8


Basically, an inline dump() method in an MC header caused several tools to suddenly depend on libCodeGen.

-- adrian