[PATCH] D56553: [WebAssembly] Support multilibs for wasm32

Mon Jan 14 12:14:52 PST 2019

sbc100 added a comment.

In D56553#1356654 <https://reviews.llvm.org/D56553#1356654>, @sunfish wrote:

> In D56553#1356467 <https://reviews.llvm.org/D56553#1356467>, @sbc100 wrote:
>
> > Ooo - a new OS is born!
>
>
>
>
> > Perhaps create a separate change to introduce the new OS?   .. which will then make this CL tiny and specific to what the CL title says it is doing.
>
> Without the new OS I wouldn't be able to fully test the new functionality, as we have no other wasm OS's in tree. Is the size of this patch an issue?

Not so much the size of the patch, but more that atomicity.   Introducing the new OS seems like an naturally separate change to me.

If you don't want to split it at least update the CL title and description.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56553/new/

https://reviews.llvm.org/D56553